Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fail2ban work again #11683

Merged
merged 5 commits into from
Dec 22, 2015
Merged

Make fail2ban work again #11683

merged 5 commits into from
Dec 22, 2015

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Dec 13, 2015

  1. fail2ban depends on the systemd python module which has changed location.
  2. There was some problem with the location of installed files (issue fail2ban: $out/etc is missing #11534).
  3. Update to the latest release (0.9.3 2015/08/01 - lets-all-stay-friends) for good measure.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @lovek323, @offlinehacker and @bjornfor to be potential reviewers

@cillianderoiste
Copy link
Member

@rvl the Travis build fails with:

error: [Errno 2] No such file or directory: '/usr/include/systemd/sd-messages.h'

Do you have chroot building enabled for nix? That might help to reproduce it.

};

buildInputs = [ unzip ];

pythonPath = (stdenv.lib.optional stdenv.isLinux systemd)
pythonPath = (stdenv.lib.optional stdenv.isLinux pythonPackages.systemd)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you use propagatedBuildInputs here

@rvl
Copy link
Contributor Author

rvl commented Dec 13, 2015

@cillianderoiste Thanks for the tip. I tried chroot building just then but couldn't get it to work. As a workaround I have removed libsystemd-dev from the debian system which I am building from. My other problem was that the travis build uses cc but my own builds use gcc.

@FRidh I have implemented your suggestions, thanks.

@jeaye
Copy link
Contributor

jeaye commented Dec 14, 2015

Looking forward to getting fail2ban working again (China really wants my root account, it seems); thanks for this.

@rvl
Copy link
Contributor Author

rvl commented Dec 17, 2015

No prob @jeaye.

Can I ask @domenkozar to kindly check the preConfigure/postInstall change (b61e057) for us?

@domenkozar
Copy link
Member

@rvl looks like #4968 that provides the current workaround method

rvl added 5 commits December 18, 2015 09:44
This module has been split out from the main systemd repository.
…ixes #11534)

Removed path substitutions from setup.py because these should be handled
by the setuptools install prefix.

Except that the install prefix won't quite work until issue #4968 is
resolved.

In the meantime there are preInstall and postInstall scripts so that
this package continues to work with the nix python packaging
improvements.
The python module has been split off from systemd since v223.
@rvl
Copy link
Contributor Author

rvl commented Dec 18, 2015

Ok great @domenkozar that explains it. I have changed it to use that workaround. However this setup.py was not as easy to sed, so there is a postInstall cleanup.

garbas added a commit that referenced this pull request Dec 22, 2015
Make fail2ban work again
@garbas garbas merged commit 38a6b5f into NixOS:master Dec 22, 2015
@garbas
Copy link
Member

garbas commented Dec 22, 2015

@rvl tnx!

@rvl
Copy link
Contributor Author

rvl commented Dec 27, 2015

@garbas thx for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants