python: fix full builds by referring to the correct interpreter (fixes #114475) #114538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 27, 2021
FRidh
commented
Feb 27, 2021
| @@ -191,6 +191,7 @@ in { | |||
| # Minimal versions of Python (built without optional dependencies) | |||
| python3Minimal = (python38.override { | |||
| self = python3Minimal; | |||
| pythonAttr = "python3Minimal"; | |||
There was a problem hiding this comment.
this one is actually unused as its used "only" for bootstrapping
The package set is an attribute of the interpreter. The function to
build an environment (`buildEnv`/`withPackages`) is part of the
interpreter. The interpreter is passed to itself, and needs to be
updated when overridden.
For cross-compilation we splice the package set, and for that the
various `build/host` interpreters and sets need to be available. We
select these currently through `pkgs.${pythonAttr}`. The `pythonAttr`
attribute was not fixed for `pythonFull`.
NixOS/rfcs#83
NixOS#104201
We need a better solution for this because this is very brittle.
|
@GrahamcOfBorg build python3Full.tests |
ofborg
bot
added
10.rebuild-darwin: 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package set is an attribute of the interpreter. The function to
build an environment (
buildEnv/withPackages) is part of theinterpreter. The interpreter is passed to itself, and needs to be
updated when overridden.
For cross-compilation we splice the package set, and for that the
various
build/hostinterpreters and sets need to be available. Weselect these currently through
pkgs.${pythonAttr}. ThepythonAttrattribute was not fixed for
pythonFull.NixOS/rfcs#83
#104201
We need a better solution for this because this is very brittle.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)