Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i3status-rust: 0.14.1 -> 0.14.2 #102199

Merged
merged 1 commit into from
Oct 31, 2020
Merged

i3status-rust: 0.14.1 -> 0.14.2 #102199

merged 1 commit into from
Oct 31, 2020

Conversation

evalexpr
Copy link
Member

@evalexpr evalexpr commented Oct 31, 2020 •
edited
Loading

Motivation for this change

New release at https://github.com/greshake/i3status-rust/releases/tag/v0.14.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from globin and Ma27 October 31, 2020 00:21
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 31, 2020
@evalexpr
Copy link
Member Author

evalexpr commented Oct 31, 2020 •
edited
Loading

I'm unsure which base for sha256 hashes is preferred, and I think the sha256- prefix is optional - can remove if desired.

SuperSandro2000
SuperSandro2000 reviewed Oct 31, 2020
View reviewed changes
pkgs/applications/window-managers/i3/status-rust.nix

src = fetchFromGitHub {
owner = "greshake";
repo = pname;
rev = "v${version}";
sha256 = "11qhzjml04njhfa033v98m4yd522zj91s6ffvrm0m6sk7m0wyjsc";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this one because it can be easier copied with one click and has better syntax highlighting in vim. Also nix-build shows me that if it is wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, have switched it over to using the base32 version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI in the long term it's planned to switch to those SRI hashes and they are already provided by default on e.g. nixUnstable. However those are interchangeable atm and it's fine to use whatever format Nix suggests, I just don't think that it's relevant to make such a change request part of a review :)

That said, I'm currently building/testing it locally and will merge if everything seems fine.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102199 run on x86_64-linux 1

1 package built:
  • i3status-rust

@Ma27 Ma27 merged commit 1ecc5c7 into NixOS:master Oct 31, 2020
@evalexpr evalexpr deleted the i3status-rust-update-0.14.2 branch October 31, 2020 11:41
@Ma27
Copy link
Member

Ma27 commented Oct 31, 2020

Thanks! Also ported to 20.09 as 86c36fc.

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Oct 31, 2020
@andir
Copy link
Member

andir commented Nov 3, 2020

I just updated my system to this version and it broke my net panel as it is unable to find ethtool. The update also doesn't look like as minor as semver suggests: greshake/i3status-rust@v0.14.1...v0.14.2

I would recommend reverting it on 20.09 as this is likely to break stable setups.

@Ma27
Copy link
Member

Ma27 commented Nov 3, 2020

Damn, sorry for that! Feel free to do this now since I'm going to bed now, otherwise I'll take care oft it tomorrow :)

@andir
Copy link
Member

andir commented Nov 3, 2020

Done, reverted in c1ffaed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@Ma27 Ma27 Ma27 approved these changes

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evalexpr @SuperSandro2000 @Ma27 @andir