Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ledger-live-desktop: 2.14.0 -> 2.15.0 #102152

Merged
merged 1 commit into from
Oct 31, 2020
Merged

ledger-live-desktop: 2.14.0 -> 2.15.0 #102152

merged 1 commit into from
Oct 31, 2020

Conversation

RaghavSood
Copy link
Member

Motivation for this change

New upstream version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@RaghavSood RaghavSood requested a review from mmahut as a code owner October 30, 2020 13:18
@ofborg ofborg bot requested a review from nyanloutre October 30, 2020 13:29
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 30, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102152 run on x86_64-linux 1

1 package built:
  • ledger-live-desktop

@mmahut mmahut merged commit 2da96f3 into NixOS:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut Awaiting requested review from mmahut

@nyanloutre nyanloutre Awaiting requested review from nyanloutre

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RaghavSood @SuperSandro2000 @mmahut