Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/activation-script: make scripts well-typed #101755

Merged
merged 1 commit into from
Nov 9, 2020
Merged

nixos/activation-script: make scripts well-typed #101755

merged 1 commit into from
Nov 9, 2020
+24 −12

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 26, 2020 •
edited
Loading

Motivation for this change

The current type of system.activationScripts doesn't allow to manipulate the dependencies or appending lines to a script.

Things done
  • Test basic activation scripts work as before
  • Run base system tests
    • boot
    • installer.simple
    • installer.simpleUefi
    • installer.simpleUefiSystemdBoot
    • mutableUsers
    • networking.scripted
    • networking.systemd
  • Run test for modules using activationScripts
    • incron
    • systemd-timesyncd
    • yggdrasil
    • nextcloud
    • transmission
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 26, 2020
dasJ
dasJ approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@dasJ dasJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally!

@rnhmjoj rnhmjoj merged commit e6b8587 into NixOS:master Nov 9, 2020
@ryantm ryantm mentioned this pull request Nov 13, 2020
Closed
10 tasks
@rnhmjoj rnhmjoj deleted the activation-type branch July 10, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ dasJ approved these changes

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnhmjoj @dasJ