Lint on broken recursion structure

[lf-]

Issue description

It's possible to write something like:

{somePackageName, stdenv}:
stdenv.mkDerivation {
  pname = "some-package-name";
  # ...
  passthru.someOtherThing = pkgs.callPackage ./something.nix { inherit somePackageName; };
}

where something in passthru doesn't follow the containing derivation's overrideAttrs properly due to broken recursion structure. The correct code here would be:

{somePackageName, stdenv}:
stdenv.mkDerivation (finalAttrs: {
  pname = "some-package-name";
  # ...
  passthru.someOtherThing = pkgs.callPackage ./something.nix { somePackageName = finalAttrs.finalPackage; };
})

I would like to have an automated lint that rejects code that exhibits this broken recursion structure: passthru referring to the parent derivation but the passthru attrs get the parent derivation from other means than finalAttrs.finalPackage.

[eclairevoyant]

Why? EDIT: makes sense as the first construct won't respect overrides.

Also, shouldn't we ensure all the builders support the finalAttrs pattern in the first place?

[lf-]

Also, shouldn't we ensure all the builders support the finalAttrs pattern in the first place?

yeah, there's a lot of very broken builders that have very broken overrides in general. we should at least fix the standard mkDerivation though.