Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
pkgs-lib/tests/formats: improve message on failure
Foremost, the message was discarding double quotes on one side of the diff, which was super-confusing to me, as I thought that the format convertor broke that when in fact only whitespace was changed. I thought I'd cat the files, but then... switching to `diff -u` seemed self-sufficient. It felt sufficiently non-controversial to push directly, but certainly feel free to improve further.
- Loading branch information
a76152a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least lemme mention @infinisil and the original PR #75584, I guess.
a76152a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, comparing serializations like this seems rather fragile, but practically the tests hopefully won't break often like 92c96b7.
a76152a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the given serialization for the tests should be read and written again with a formatter