Fix cargo upgrade to not break by using --incompatible
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philiptaron
approved these changes
Dec 3, 2024
While `--incompatible` allows jumping to the next major version. it also means it doing so breaks the build then the auto PR will break every week. Remove that and we can see there are pending new major version numbers via `cargo outdated`.
philiptaron
force-pushed
the
fix-cargo-upgrade-incompatible
branch
from
6003015 to
8a47cf9
Compare
|
Thanks for the PR, @willbush. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: #130 (comment)
While
--incompatibleallows jumping to the next major version, it also means if doing so breaks the build, then the auto PR will break every week. Remove that and we can see there are pending new major version numbers via `cargo outdated'. This will require manual intervention.