Global vs per-user profiles and channels #8147
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
force-pushed
the
global-profile-flags
branch
from
a1baec6 to
54123b0
Compare
Ericson2314
force-pushed
the
global-profile-flags
branch
2 times, most recently
from
304acaa to
adf8f48
Compare
github-actions
bot
added
the
with-tests
|
🎉 All dependencies have been resolved ! |
Ericson2314
force-pushed
the
global-profile-flags
branch
from
adf8f48 to
0e1fe69
Compare
github-actions
bot
removed
the
with-tests
Ericson2314
force-pushed
the
global-profile-flags
branch
3 times, most recently
from
221c768 to
d2f2c46
Compare
Ericson2314
force-pushed
the
global-profile-flags
branch
from
d2f2c46 to
7d1fc4d
Compare
|
🎉 All dependencies have been resolved ! |
Ericson2314
force-pushed
the
global-profile-flags
branch
from
7d1fc4d to
2c75e65
Compare
Ericson2314
requested review from
thufschmitt,
fricklerhandwerk and
edolstra
as code owners
edolstra
added
the
idea approved
|
Triaged in the Nix team meeting today Idea approved, assigned to @tomberek
|
tomberek
reviewed
Aug 20, 2023
Ericson2314
force-pushed
the
global-profile-flags
branch
from
708694c to
963b079
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-08-18-nix-team-meeting-minutes-80/32081/1 |
tomberek
requested changes
Aug 25, 2023
There was a problem hiding this comment.
Needs a bare-minimum of testing for the existence and sanity checking of the commands. Likely small modifications to the existing profile tests. This should not be a blocker - no need for exhaustiveness beyond existing test coverage.
eg: in user-envs.sh, running --global-profile seems to give the same results as --user-profile.
# Query installed: should contain foo-1.0 now (which should be
# executable).
test "$(nix-env -q '*' | wc -l)" -eq 1
test "$(nix-env --user-profile -q '*' | wc -l)" -eq 1
test "$(nix-env --global-profile -q '*' | wc -l)" -eq 0
nix-env -q '*' | grepQuiet foo-1.0
test "$($profiles/test/bin/foo)" = "foo-1.0"
427c5c3 to
fd0a006
Compare
github-actions
bot
added
the
with-tests
Ericson2314
force-pushed
the
global-profile-flags
branch
from
fd0a006 to
8ef788e
Compare
The motivation for this is basically explained in the contribution guide, as guidance on how to design features like this going forward. In short, I think it is confusing for operations acting on the default profile to *always* do something different based on whether the user is regular or root. Instead, this makes there be flags which are (from the vantage point of today) "do the root default" vs "do the regular user" default. This make the situation teachable: we can point to the flags, and the conditional default, as *exactly* what varies between the root and non-root cases. And by manually specifying enough flags, we can ensure those defaults are overridden and Nix will indeed do the same thing (or fail trying). This is similar to the logic behind the supplementary group setting (NixOS#8342), which I also discuss in this new section of the contribution guide as a second example. Instead of creating the default dirs in `getDefaultProfile` (which is a bit odd if the symlink points elsewhere), create the profile dir for the chosen profile in `createGeneration`. That seems more appropriate and keeps the test added in e997512 (where the profiles are deleted but the symlink isn't) working.
Ericson2314
force-pushed
the
global-profile-flags
branch
from
8ef788e to
6a378f5
Compare
github-actions
bot
added
documentation
contributor-experience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The motivation for this is basically explained in the contribution guide, as guidance on how to design features like this going forward.
In short, I think it is confusing for operations acting on the default profile to always do something different based on whether the user is regular or root.
Instead, this makes there be flags which are (from the vantage point of today) "do the root default" vs "do the regular user" default. This make the situation teachable: we can point to the flags, and the conditional default, as exactly what varies between the root and non-root cases. And by manually specifying enough flags, we can ensure those defaults are overridden and Nix will indeed do the same thing (or fail trying).
Context
This is similar to the logic behind the supplementary group setting (#8342), which I also discuss in this new section of the contribution guide as a second example.
depends on #8351depends on #8735Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 👍 to pull requests you find important.