Fix tests/user-envs-migration.sh
#8079
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I rather know exactly what check failed than get a nice error message. I'll go to the line if there is a failure, and then see the comment above.
It was changed from `XDG_DATA_HOME` to `XDG_STATE_HOME` during review, but it was forgetten to update this test.
The version was based on when this PR was first created; by the time it was merged the test was dead code as we no longer tested a Nix version that old.
github-actions
bot
added
the
with-tests
thufschmitt
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Thanks :)
Things like a29abc9 are a fairly easy and frequent source of bugs, I wonder whether we could do something about them
thufschmitt
reviewed
Mar 20, 2023
Comment on lines
+29
to
+31
| # The nix profile should point to the new location | ||
| [[ -L ~/.nix-profile ]] | ||
| [[ $(readlink ~/.nix-profile) == ~/.local/state/nix/profiles/profile ]] |
There was a problem hiding this comment.
Wait, that section is actually completely broken, I removed this migration from the original PR after some review suggested it 🤔 . So ~/.nix-profile should still point to the original location
There was a problem hiding this comment.
Ha! Sorry, I should have marked this as draft as I opened it before tests. So I guess we can instead test that the migration doesn't happen until later OK.
Will rework.
(And I realized how I can run the tests incrementally, just define the env var. Whew. That helps.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See each commit for details.
Context
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 👍 to pull requests you find important.