Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move settings from Settings to LocalStoreConfig #7740

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ericson2314
Copy link
Member

Motivation

Trying to do #5638 but this is not working very well at all.

Context

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or bug fix: updated release notes

@Ericson2314 Ericson2314 mentioned this pull request Feb 3, 2023
86 tasks
Trying to do NixOS#5638 but this is not working very well at all.
@Ericson2314 Ericson2314 force-pushed the move-local-store-settings branch from ed6a756 to 1c34b9f Compare February 3, 2023 14:38
@roberth roberth self-assigned this Feb 13, 2023
@thufschmitt thufschmitt added this to the CLI Stabilisation milestone Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants