evaluate phases in nix develop the same way as genericBuild

[arianvp]

This way nix develop [--configure|--build] works with meson, cmake etc; which set the xxxPhase= environment variable instead of overriding the xxxPhase function.

open question. I think in these cases foundMakefile=1 should not be set. But we'd need to fix that in https://github.com/NixOS/nixpkgs/blob/master/pkgs/stdenv/generic/setup.sh first I think

[kira-bruneau]

Thanks for this fix @arianvp! I noticed this problem too, but never really looked into it before 😅

open question. I think in these cases foundMakefile=1 should not be set. But we'd need to fix that in https://github.com/NixOS/nixpkgs/blob/master/pkgs/stdenv/generic/setup.sh first I think

Hmm, yeah. It looks like checkPhase and installCheckPhase should check for the makefile themselves so they aren't dependent on the buildPhase. I wonder how many other places we have dependencies between phases like this?

[firestack]

uhhhh, related? flox@c03252c

#6202

[thufschmitt]

Duh, I though that's what runHook was meant to do 😕

Thanks for the fix then :) That looks good (well, it's literally what the stdenv does, so it better be…)

Can you just add a test for that? I guess you can add a new derivation (with a custom buildPhase) in tests/shell.nix and run nix develop --build on it in tests/nix-shell.sh.

[arianvp]

It feels more elegant to fix stdenv. Let me give that a try first

[thufschmitt]

It feels more elegant to fix stdenv. Let me give that a try first

All right 👍

I'll close the PR in the meantime, feel free to reopen it if the stdenv fix doesn't work out well