Allow testing ssh:// and ssh-ng:// across versions too
#5602
Conversation
Ericson2314
force-pushed
the
test-ssh-across-versions
branch
2 times, most recently
from
5d11d69 to
53ebc3d
Compare
|
🎉 All dependencies have been resolved ! |
src/libstore/legacy-ssh-store.cc
Outdated
| const Setting<Path> remoteProgram{(StoreConfig*) this, "nix-store", "remote-program", "path to the nix-store executable on the remote system"}; | ||
| const Setting<Path> remoteProgram{ | ||
| (StoreConfig*) this, | ||
| getEnv("NIX_LEGACY_SSH_REMOTE_PROGRAM").value_or("nix-store"), |
There was a problem hiding this comment.
There is a bit of a convention to prefix these variable with _NIX_TEST_. Alternatively, we can avoid the environment variable by appending ?remote-program=... to the store URL.
There was a problem hiding this comment.
I switched it to _NIX_TEST_ instead. As to ?remote-program=... I can pursue if you want, but do note we have some fancy ssh urls e.g. doing iterative ssh with ?remote-store= so it is a bit a non-trivial. I am thinking the env var might be better because it means no one can forget the remote program part going forward if they are adding another ssh test, especially if it is also has complicated store URLs.
Ericson2314
force-pushed
the
test-ssh-across-versions
branch
from
53ebc3d to
01f2a6a
Compare
|
Is this OK now? Would be nice to merge. |
|
Actually while this is OK, it’s a bit limited in what it can test, because when |
|
Ah good point. Maybe let's start with this, just because it's not worse than today? |
Ericson2314
changed the title
ssh:// and ssh-ng:// across versions toossh:// and ssh-ng:// across versions too
Ericson2314
force-pushed
the
test-ssh-across-versions
branch
2 times, most recently
from
6d98e46 to
4bf2dd5
Compare
|
I marked this as stale due to inactivity. → More info |
|
@andir an example of one of my PRs relating to cross version testing. It might be nice to do call to page it all back in and answer any questions you have. |
fricklerhandwerk
added
the
with-tests
We want to make sure both protocols don't break. Also recall ssh-ng:// will be slightly different than unix:// because the former transfers files over the protocol too. Add env vars for the remote (ssh/ssh-ng) store programs, we will use them in the test suite soon.
Ericson2314
force-pushed
the
test-ssh-across-versions
branch
from
4bf2dd5 to
4875e58
Compare
github-actions
bot
added
store
We want to make sure both protocols don't break. Also recall
ssh-ng://will be slightly different thanunix://because the former transfers files over the protocol too.I am not sure what the status of adding new configuration env vars is. I hope if
NIX_DAEMON_SOCKETpath was OK, these too are too, but if not I suppose we could try to sneak and shove some?remote-command=...into the tests.depends on #5598The dependency is mainly to avoid merge conflicts.