nix store repair --keep-going
#11877
Draft
+27
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can recognize it in an upcoming commit.
roberth
added
new-cli
roberth
commented
Nov 13, 2024
Comment on lines
+24
to
+29
| // Remove duplicates. | ||
| StorePathSet storePathsSet; | ||
| for (auto & path : storePaths) | ||
| store->repairPath(path); | ||
| storePathsSet.insert(path); | ||
|
|
||
| for (auto & path : storePathsSet) { |
There was a problem hiding this comment.
This should be bottom-up, ie dependencies first. That way when we do a "substitution fallback" build, we don't use broken inputs.
bryanhonof
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix what we can.
Tested in anger before adding
RepairFailure.TODO
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.