-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add challenge-response method for KeepassXC support #64
Conversation
Regarding PKCS#7 padding: I don't think the current implementation is correct. I think we should instead use the |
Yup, that's correct indeed - this is Yubikey's "PKCS#7 padding" version. To do:
Edit: I have noted that down in the Python tests, but here it would be nice to have it as well |
We might need to support it bug-for-bug. If there are any other applications, they probably have it implemented like this anyway. To discuss.
I suppose we can use it, once we take into account the non-standard PKCS#7 input, and correct it beforehand. |
Review corrections were added in #71. Please verify briefly. |
Add support for KeepassXC through challenge-response method.
Tests: Nitrokey/pynitrokey#384
KeepassXC integration: keepassxreboot/keepassxc#9397
Does not contain PWS: #63With PWS now.Incompatible changes:
To discuss:
To do in the next PRs:
To test later:
Fixes #61