Generate rules with Python #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daringer
approved these changes
Dec 14, 2024
robin-nitrokey
commented
Dec 15, 2024
Comment on lines
+101
to
+102
| # Nitrokey Storage dev Entry | ||
| KERNEL=="sd?1", ATTRS{idVendor}=="20a0", ATTRS{idProduct}=="4109", SYMLINK+="nitrospace" |
There was a problem hiding this comment.
I forgot to mention – this rule looks somewhat misplaced. I understand it’s for development? Should we just remove it from the official rules?
sosthene-nitrokey
approved these changes
Dec 16, 2024
This patch adds a Python script to generate the udev rules. The required data is defined in a TOML file. This makes the rules easier to maintain and update. This causes some small changes in the formatting of the rules. Also, the rule for the Nitrokey Storage bootloader is updated to use ATTRS instead of ATTR for consistency with similar rules.
robin-nitrokey
force-pushed
the
generate
branch
from
9ca5120 to
922e0f9
Compare
|
Merged with the unclear Nitrokey Storage rule to keep the status quo. We can still remove it in another PR. |
|
Hi!
It's a feature actually - this makes a symlink to a first partition of the
connected Nitrokey Storage, regardless of what block device it was assigned
to (so nitrospace -> sda1, if Nitrokey Storage was assigned to sda, sdb1 if
sdb etc.). This way one could always run `mount /dev/nitrospace
/mnt/nitrokey`.
I've never heard anyone is using this one though, so I assume it's safe to
remove (perhaps I was using this internally). Now with the volume/partition
label based mounting this could be a little outdated as well.
Note, that this rule works just for a single device case. It would need to
be corrected for the multiple Nitrokey Storage devices connected.
pon., 16 gru 2024 o 08:27 jans23 ***@***.***> napisał(a):
… ***@***.**** commented on this pull request.
------------------------------
In generate.py
<#5 (comment)>
:
> + # Nitrokey Storage dev Entry
+ KERNEL=="sd?1", ATTRS{idVendor}=="20a0", ATTRS{idProduct}=="4109", SYMLINK+="nitrospace"
@szszszsz <https://github.com/szszszsz> Any idea, opinion?
—
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEBXW4Q7G545KBCC5EKAKFT2FZ6E7AVCNFSM6AAAAABTTPHZKCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMBVGM2DGNBYHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@szszszsz Thanks for the explanation! Let’s remove it from the general rules then. Users can still add a custom rule based on their setup and device. |
robin-nitrokey
added a commit
that referenced
this pull request
Dec 21, 2024
See the discussion in #5.
robin-nitrokey
added a commit
that referenced
this pull request
Dec 21, 2024
See the discussion in #5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a Python script to generate the udev rules. The required data is defined in a TOML file. This makes the rules easier to maintain and update.
This causes some small changes in the formatting of the rules. Also, the rule for the Nitrokey Storage bootloader is updated to use ATTRS instead of ATTR for consistency with similar rules.