Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nightly toolchain for test releases #516

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Remove nightly toolchain for test releases #516

merged 1 commit into from
Jun 25, 2024

Conversation

sosthene-nitrokey
Copy link
Collaborator

No description provided.

@nitrokey-ci
Copy link
Collaborator

nitrokey-ci commented Jun 21, 2024 •
edited
Loading

metric value change
binary-size-nk3xn-test 576,884 🔴 +34,692 (+6.40%)
Insignifcant changes
metric value change
binary-size-nk3am 1,399,105 ⚪ +0 (+0.00%)
binary-size-nk3am-test 2,004,059 ⚪ +0 (+0.00%)
binary-size-nk3xn 502,400 ⚪ +0 (+0.00%)
binary-size-nkpk 727,106 ⚪ +0 (+0.00%)

@sosthene-nitrokey sosthene-nitrokey marked this pull request as ready for review June 21, 2024 13:17
robin-nitrokey
robin-nitrokey approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase before merging so that we have the current numbers trackend in the metrics comment.

@sosthene-nitrokey sosthene-nitrokey merged commit 7f857be into main Jun 25, 2024
9 checks passed
@sosthene-nitrokey sosthene-nitrokey deleted the remove-nightly branch June 25, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robin-nitrokey robin-nitrokey robin-nitrokey approved these changes

@daringer daringer daringer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sosthene-nitrokey @nitrokey-ci @daringer @robin-nitrokey