Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Netlify Analytics API v1 deprecation & switch to v2 #10

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

DavidM42
Copy link
Collaborator

Looks like a super simple fix...for now.
I checked in the network tab of the Netlify dashboard and the requests looked exactly like in v1 only with the v1 replaced with v2.

Local testing of index.js execution with this change seemed to worked, but I'd like to first test the whole workflow of our blog with this.
Can you get a feature package version published for us to test in our blog actions workflow with @NiklasMerz ?
If that works, we should merge this soon

* for now just changed api version in url nothing else seemingly
@DavidM42 DavidM42 requested a review from NiklasMerz November 17, 2021 18:12
@NiklasMerz
Copy link
Owner

Thanks @DavidM42. We can test your branch in our blog the next few days and then release version 2 of this action with API V2

@NiklasMerz NiklasMerz linked an issue Nov 17, 2021 that may be closed by this pull request
@NiklasMerz NiklasMerz merged commit fd900b0 into main Nov 18, 2021
@NiklasMerz NiklasMerz deleted the fix/api-v1-deprecation-v2-switch branch November 18, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use V2 API
2 participants