android: handle onAuthenticationFailed #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
onAuthenticationFailedmethod was not implemented to do something. This seems to be no problem on many devices since the biometric prompt allows a retry and just callsonAuthenticationErrorafter too many failed attempts. This is the case on the emulator for example.OnePlus chose to implement this differently (on the 6T at least) for some reason. The biometric prompt does not have a UI and after a failed attempt seems to be stuck until you press cancel. This fixes that by implementing the method and calling the error callback back to Cordova.
Closes #247