fix: disabled built in auth/vesting module functionality

[onikonychev]

• Prevents vulnerability https://github.com/code-423n4/2024-11-nibiru-findings/issues/60

Cosmos built-in auth/vesting feature is not used, all vesting is managed by Wasm contracts

Summary by CodeRabbit

• New Features

  • The vesting module has been completely removed from the application.

• Bug Fixes

  • Resolved issues related to the built-in authentication and vesting module functionality, which has been disabled.

[coderabbitai]

Walkthrough

The pull request involves the complete removal of the vesting module from the app/keepers.go file. This change eliminates all references to the vesting functionality, including the deletion of import statements, the removal of the module from the initialization order, and its exclusion from the module basic manager setup. Additionally, the changelog has been updated to document this change, noting the disabling of the built-in authentication and vesting module functionality.

Changes

File	Change Summary
app/keepers.go	- Deleted vesting module import statements - Removed vestingtypes.ModuleName from orderedModuleNames - Removed vesting.AppModuleBasic{} from ModuleBasicManager
CHANGELOG.md	- Added entry for disabling built-in auth/vesting module functionality: - [#2127] - fix: disabled built in auth/vesting module functionality

Poem

🐰 Farewell, vesting module, you're now out of sight
No more tokens locked with such tight might
In keepers we clean, with surgical grace
A rabbit's swift edit leaves not a trace
Modules come, modules go - that's our code's delight! 🔧

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

CHANGELOG.md (1)

54-54: Enhance the changelog entry with more context and PR link.

The changelog entry should provide more context about why the auth/vesting module was disabled and include a link to the PR. Consider expanding it to:

-- [#2127] - fix: disabled built in auth/vesting module functionality
+- [#2127](https://github.com/NibiruChain/nibiru/pull/2127) - fix: disabled built in auth/vesting module functionality to address security vulnerability, as all vesting operations are managed through Wasm contracts

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5cacee7 and 8f2803f.

📒 Files selected for processing (1)

• CHANGELOG.md (1 hunks)

🔇 Additional comments (1)

CHANGELOG.md (1)

Line range hint 1-1182: LGTM! The changelog format and structure are well-maintained.

The changelog follows the Keep a Changelog format, has clear sections for different types of changes, and includes helpful guiding principles and usage instructions.