fix id when common tags are after metric data #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the common tags were after the metric data in the batch json payload, then the tags in the tuple would get updated, but not the id. This change fixes it so that the id is updated based on the final tags for a metric. Also updates the behavior so the conflicts resolution is consistent for both paths.
manolama
approved these changes
Apr 28, 2022
manolama
pushed a commit
to manolama/atlas
that referenced
this pull request
May 22, 2024
If the common tags were after the metric data in the batch json payload, then the tags in the tuple would get updated, but not the id. This change fixes it so that the id is updated based on the final tags for a metric. Also updates the behavior so the conflicts resolution is consistent for both paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the common tags were after the metric data in the batch
json payload, then the tags in the tuple would get updated,
but not the id. This change fixes it so that the id is
updated based on the final tags for a metric. Also updates
the behavior so the conflicts resolution is consistent for
both paths.