fix memory leak for failed streams #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BroadcastHub doesn't complete if there are still items pending. When the subscriber failed, the failure wasn't propagated up since the BroadcastHub can have another subscriber come along later. Change it to use a publisher with no fanout, this will fail along with the connected downstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BroadcastHub doesn't complete if there are still items
pending. When the subscriber failed, the failure wasn't
propagated up since the BroadcastHub can have another
subscriber come along later. Change it to use a publisher
with no fanout, this will fail along with the connected
downstream.