Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make JsonSupport.toJson final #1405

Merged
merged 1 commit into from
Jan 7, 2022
Merged

make JsonSupport.toJson final #1405

merged 1 commit into from
Jan 7, 2022

Conversation

brharrington
Copy link
Contributor

Users should override encode to customize and can
get confusing results if only toJson is overridden.
Also updates the toJson to ensure the generator will
be cleaned up if encode throws an exception.

@brharrington
make JsonSupport.toJson final
d7484b7 
Users should override `encode` to customize and can
get confusing results if only `toJson` is overridden.
Also updates the `toJson` to ensure the generator will
be cleaned up if `encode` throws an exception.
@brharrington brharrington added this to the 1.7.0 milestone Jan 7, 2022
@brharrington brharrington requested a review from manolama January 7, 2022 13:55
manolama
manolama approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@manolama manolama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manolama manolama merged commit e1b8296 into Netflix:master Jan 7, 2022
@brharrington brharrington deleted the json-final branch January 7, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manolama manolama manolama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@brharrington @manolama