use array instead of int map for itemTags #1357
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The itemTags field of the index is only used for findKeys
and findValues. In the findKeys case it loops over all keys
and the simple array is faster. For the findValues case, it
gets the value for a key which is now linear for the number
of tags so will be a bit slower.
The main benefit is it can reduce the memory use considerably
for large indexes. The IntIntHashMap has an overhead of 40
bytes and also allocates an array of 2x the size to avoid
collisions in the map. With a sample index of 10M items this
change reduced the memory size by several GB.