Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle AuthorizationFailedRejection #1339

Merged
merged 1 commit into from
Sep 16, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/*
* Copyright 2014-2021 Netflix, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.netflix.atlas.akka

import akka.http.scaladsl.model.StatusCode
import akka.http.scaladsl.server.Rejection

/**
* Rejection type that can be used with the RequestHandler to fully customize the status
* code and diagnostic message returned to the user.
*/
case class CustomRejection(status: StatusCode, message: String) extends Rejection
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import akka.http.scaladsl.model.StatusCode
import akka.http.scaladsl.model.StatusCodes
import akka.http.scaladsl.model.headers.RawHeader
import akka.http.scaladsl.server.AuthenticationFailedRejection
import akka.http.scaladsl.server.AuthorizationFailedRejection
import akka.http.scaladsl.server.CircuitBreakerOpenRejection
import akka.http.scaladsl.server.Directives._
import akka.http.scaladsl.server.MalformedRequestContentRejection
Expand Down Expand Up @@ -226,6 +227,10 @@ object RequestHandler extends StrictLogging {
error(StatusCodes.MethodNotAllowed, s"method not allowed: ${m.name()}")
case AuthenticationFailedRejection(_, _) =>
error(StatusCodes.Forbidden, "not authorized")
case AuthorizationFailedRejection =>
error(StatusCodes.Unauthorized, "not authorized")
case CustomRejection(status, message) =>
error(status, message)
case r: Rejection =>
error(StatusCodes.BadRequest, r.toString)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -223,4 +223,10 @@ class RequestHandlerSuite extends AnyFunSuite with ScalatestRouteTest {
assert(response.status === StatusCodes.ServiceUnavailable)
}
}

test("authorization rejection") {
Post("/unauthorized") ~> routes ~> check {
assert(response.status === StatusCodes.Unauthorized)
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,11 @@ class TestApi(val system: ActorSystem) extends WebApi {
case Failure(e) => complete(StatusCodes.InternalServerError, e.getMessage)
}
}
} ~
path("unauthorized") {
authorize(false) {
complete(StatusCodes.OK)
}
}
}
}