Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mapping for AWS neptune metrics with dimension of cluster and role. #1296

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

jfz
Copy link
Contributor

@jfz jfz commented Apr 23, 2021

AWS Neptune metrics by "cluster and role" are published as separate time series, need to add them in addition to existing ones that are by instance or cluster only.

@jfz jfz marked this pull request as draft April 23, 2021 04:31
@brharrington brharrington added this to the 1.7.0 milestone Apr 23, 2021
@jfz jfz requested a review from brharrington April 27, 2021 16:41
@jfz jfz marked this pull request as ready for review April 27, 2021 16:41
@jfz
Copy link
Contributor Author

jfz commented Apr 27, 2021

Metrics are published either with dimension of either "DBClusterIdentifier + Role" or "DBInstanceIdentifier".

Copy link
Contributor

@brharrington brharrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unfortunate they have disjoint dimensions for the same metrics. The downside to mapping in both is that if the user just queries based on the name, then they would get duplication since it will match both sets.

Are both really needed? Maybe it would be better to just map in the cluster/role set to minimize the risk of confusion.

@jfz
Copy link
Contributor Author

jfz commented Apr 27, 2021

It is unfortunate they have disjoint dimensions for the same metrics. The downside to mapping in both is that if the user just queries based on the name, then they would get duplication since it will match both sets.

Are both really needed? Maybe it would be better to just map in the cluster/role set to minimize the risk of confusion.

Users like to use both, I think it wouldn't be too confusing since the dimension sets do not overlap.

@brharrington
Copy link
Contributor

I think it wouldn't be too confusing since the dimension sets do not overlap.

The issue is more that you have to select both name and one of those other dimensions to get a meaningful aggregate. Typically we recommend structuring data so that it can be meaningfully aggregated if just the name is selected and the dimensions can be used to drill down into the data.

@brharrington brharrington merged commit 44d557e into Netflix:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants