Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mapping for Neptune metrics #1291

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Conversation

jfz
Copy link
Contributor

@jfz jfz commented Apr 15, 2021

No description provided.

@brharrington brharrington added this to the 1.7.0 milestone Apr 15, 2021
@@ -306,6 +306,9 @@ atlas {
"lambda",
"lambda-fn-res",
"nat-gateway",
"neptune",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neptune config needs to be included below.

// https://docs.aws.amazon.com/neptune/latest/userguide/cw-metrics.html
neptune = {
namespace = "AWS/neptune"
period = 1m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs say everything is 5m, does that not match what we actually see?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, most of them actually are being published minutely

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how neptune data is reported and if this would apply, but for EC2 data at the auto-scaling group level can sometimes appear to be minute level even though the samples from each node making up the ASG are only reported every 5m. This is because each node reports independently and may not be aligned to 5m boundaries. So some nodes report at minutes 0, 5, 10, 15, ... and some other nodes report at 1, 6, 11, 16, ... and so on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that it's minutely for individual instance too.

# Metrics published at cluster level, every 5 minutes
neptune-cluster-5m = {
namespace = "AWS/neptune"
period = 1m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't it using a 5m period?

# Metrics published at cluster level, once per day
neptune-cluster-1d = {
namespace = "AWS/neptune"
period = 1m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this use a 1d period?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was worried about big period making data stable, but I think I can avoid it by setting "end-period-offset" to 0 in such case.


// https://docs.aws.amazon.com/neptune/latest/userguide/cw-metrics.html
neptune = {
namespace = "AWS/neptune"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it is case sensitive, but looks like it should be AWS/Neptune

{
name = "GremlinRequestsPerSec"
alias = "aws.neptune.requests"
conversion = "max"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be sum,rate?

{
name = "NumTxCommitted"
alias = "aws.neptune.transactions"
conversion = "max"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs claim this is a rate per second, should it be sum,rate?

metrics = [
{
name = "VolumeBytesUsed"
alias = "aws.neptune.volumneBytesUsed"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/volumneBytesUsed/volumeBytesUsed/

@brharrington brharrington merged commit 775c445 into Netflix:master Apr 15, 2021
@jfz jfz deleted the neptune-metrics branch April 17, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants