enable WRITE_NAN_AS_STRINGS by default #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically some endpoints wrote the special double values without quotes to make it clear they were numeric. However, that creates problems with tools using standard JSON parsing libraries. New uses should always emit standard JSON so this change updates the default so these values are quoted. The encoding for the legacy `json` format on the graph API still emits data without the quotes for backwards compatibility.
jfz
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically some endpoints wrote the special double values
without quotes to make it clear they were numeric. However,
that creates problems with tools using standard JSON parsing
libraries. New uses should always emit standard JSON so this
change updates the default so these values are quoted.
The encoding for the legacy
jsonformat on the graph APIstill emits data without the quotes for backwards compatibility.