even out tick distance in graph if value range is big #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ticks.result() | ||
| } | ||
|
|
||
| def getLogMajorStepSize(min: Double, max: Double, n: Int): Int = { |
There was a problem hiding this comment.
Should this be private?
| while (curr <= max) { | ||
| //show tick for 0 but not 1(10^0) if lower boundary is 0, because they are too close in log scale | ||
| val v = if (v1 == 0 && curr == 0) 0 else math.pow(10, curr) | ||
| //val v = math.pow(10, curr) |
There was a problem hiding this comment.
Remove commented out code
|
This doesn't work correctly for negative values. The new rendering would give me the impression the smaller values are greater than 0 and less than 1. Before
After
|
brharrington
approved these changes
Nov 9, 2019
| @@ -47,7 +47,7 @@ sealed trait ValueAxis extends Element with FixedWidth { | |||
| val numTicks = (y2 - y1) / minTickLabelHeight | |||
| plotDef.tickLabelMode match { | |||
| case TickLabelMode.BINARY => Ticks.binary(min, max, numTicks) | |||
There was a problem hiding this comment.
We can hit the same problem with the binary mode, example:
/api/v1/graph?q=10,100,1e5,1e8&scale=log&tick_labels=binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1007