Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add percentile example #1072

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jul 26, 2019

I have made an attempt to better understand percentiles in Atlas and hopefully address this issue as well: #718.

Given the following request latencies:

image

And applying the example query yields the following result:
name,requestLatency,:eq,(,25,50,90,),:percentiles

image

Unfortunately, from the generated docs, the input graph looks as follows, due to aggregation:
image

Obviously having percentiles generate from a single input does not make sense, therefore ideally it would be possible to generate the example input using :all, but I didn't pursue this route any further.

Please let me know if I can enhance the example in any way!

@ghost
Copy link
Author

ghost commented Jul 26, 2019

As a follow up, I am happy to add some notes on my findings as a separate PR (issue #347).

@ghost ghost changed the title Add percentile example [WIP] Add percentile example Jul 26, 2019
@ghost ghost changed the title [WIP] Add percentile example Add percentile example Jul 26, 2019
@brharrington
Copy link
Contributor

Thanks for the contribution. I'm out of office until next week, but will look into the example then.

@brharrington brharrington added this to the 1.7.0 milestone Jul 29, 2019
@brharrington
Copy link
Contributor

There is a work in progress to migrate the documentation to: https://github.com/Netflix/atlas-docs. This should make it easier to contribute to as well as give some more control over some of the aspects. The auto-generated examples are convenient in some ways, but often have restrictions that make them less than ideal for conveying the information.

@brharrington brharrington merged commit 35753f3 into Netflix:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants