Readability refactor #688
Merged
Readability refactor #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored code for readability. Split out most sections into self-contained methods with a single objective. Code is now longer, but less convoluted and with less anonymous nested things. Cleaned up compiler warnings in main class and in the corresponding unit tests.
akang31
approved these changes
Oct 20, 2023
|
|
||
| if (immutable) { | ||
| // Cache the current value of the property and always return that. | ||
| // Note that this will fail for parametrized properties! |
There was a problem hiding this comment.
There are a few instances where parameterized is misspelled parametrized
There was a problem hiding this comment.
Oh it looks like both are valid, but I think it'd be best if we stuck with one or the other regardless
There was a problem hiding this comment.
LOL, thanks for catching this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored code for readability. Split out most sections into self-contained methods with a single objective. Code is now longer, but less convoluted and with less anonymous nested things.
Cleaned up compiler warnings in main class and in the corresponding unit tests.