Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Hystrix Dashboard with play framework #1164

Closed
voodoo719 opened this issue Mar 30, 2016 · 5 comments
Closed

Integrating Hystrix Dashboard with play framework #1164

voodoo719 opened this issue Mar 30, 2016 · 5 comments

Comments

@voodoo719
Copy link

Currently I am running play version 2.2.3. I am trying to integrate Hystrix Dashboard into my application but as it turns out hystrix-metrics-event-stream works with servlet containers like tomcat, JBoss..etc. Is there any way to get it running with play framework in Java. Deploying my play application as a WAR file is not an option.

@mattrjacobs
Copy link
Contributor

The HystrixMetricsStreamServlet is one way to use the HystrixMetricsPoller. You may choose to embed HystrixMetricsPoller any way you'd like in your Play application. I'm not personally familiar with Play, but I think the basic shape would be that you map a metrics route to code which invokes the HystrixMetricsPoller, and outputs that data as an HTTP stream.

@kennedyoliveira
Copy link
Contributor

@voodoo719, you can use hystrix-vertx-metrics-stream, it's a vert.x implementation, but can be embedded in any project on JVM, even if you are not using vert.x, and doesn't need a servlet container.

@agentgt
Copy link
Contributor

agentgt commented Apr 1, 2016

I'm not sure of its quality but I think the rxnetty version (hystrix-rx-netty-metrics-stream) would (or should be) the ideal implementation since both Play and Vertx use the same libraries (netty).

In fact I would say the rxnetty should be the canonical choice for almost all since it can be embedded in almost anything and has many of the same dependencies has Hystrix does albeit it does require opening up another port. This is one of the reasons I'm not sure if its worth doing #1123 .

@kennedyoliveira
Copy link
Contributor

@agentgt, the vertx and rxnetty implementations are basically the same, the vertx one can be embedded in basically anything too, this was the purpose through, if the project is not using already vertx or rxnetty i think choosing between one of em doesn't makes much diference, he can pick whatever he thinks is more easily, both has the same "limitation" that need to open another port.

By the way, i agree with you about the #1123, i don't know if is worth doing it, since the vertx and rxnetty metrics implementation are both lightweight and pretty simple to implement, and non blocking.

@mattrjacobs
Copy link
Contributor

Closing due to inactivity. Please re-open if there's more to discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants