-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async 3.x metric servlets #1123
Comments
@mattrjacobs I am interested, can we talk about it? |
@fcalderonnearsoft Sure, we can use this comment thread to discuss the implementation. Thanks for your interest - it is much appreciated! @agentgt, please feel free to jump in if you're interested. I think the main goal should be to add a new servlet implementation that uses the Using the async features should mean that receiving the HTTP GET results in a timer getting created ( This is what I gathered from reading about Servlet 3.x features. I'm excited to see how this fits together, and would love any corrections to my description of the work to do. |
Its been a while since I have used Servlet 3.0 directly (I have used wrapping libraries) but if no one picks it up I'll look into it. We don't use the Hystrix dashboard (we use codahale metrics) so I'm probably not the best one to test this functionality. |
@mattrjacobs I liked your idea, I am not a expert on Servlet 3.0 but I will look into it. @agentgt If you decide to participate I would like to help you. |
Closing due to inactivity |
As mentioned by @agentgt in #1117 (comment), using async servlets is more appropriate for server-push streams like these metric streams.
Not everyone might be able to use these, so the blocking servlets should stick around to not break backwards-incompatibility.
The text was updated successfully, but these errors were encountered: