Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve install #144

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

felipemadeiros
Copy link

@felipemadeiros felipemadeiros commented Apr 5, 2023

WHAT

  • Improve lib requirements on central file requirement.txt and configure setup.py to read dependencies from that file.
env) $ aardvark config
Traceback (most recent call last):
  File "/home/ssm-user/aardvark/env/bin/aardvark", line 11, in <module>
    load_entry_point('aardvark', 'console_scripts', 'aardvark')()
  File "/home/ssm-user/aardvark/env/lib/python3.8/site-packages/pkg_resources/__init__.py", line 489, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/home/ssm-user/aardvark/env/lib/python3.8/site-packages/pkg_resources/__init__.py", line 2852, in load_entry_point
    return ep.load()
  File "/home/ssm-user/aardvark/env/lib/python3.8/site-packages/pkg_resources/__init__.py", line 2443, in load
    return self.resolve()
  File "/home/ssm-user/aardvark/env/lib/python3.8/site-packages/pkg_resources/__init__.py", line 2449, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/home/ssm-user/aardvark/aardvark/__init__.py", line 14, in <module>
    db = SQLAlchemy()
  File "/home/ssm-user/aardvark/env/lib/python3.8/site-packages/Flask_SQLAlchemy-2.5.1-py3.8.egg/flask_sqlalchemy/__init__.py", line 758, in __init__
    _include_sqlalchemy(self, query_class)
  File "/home/ssm-user/aardvark/env/lib/python3.8/site-packages/Flask_SQLAlchemy-2.5.1-py3.8.egg/flask_sqlalchemy/__init__.py", line 112, in _include_sqlalchemy
    for key in module.__all__:
AttributeError: module 'sqlalchemy' has no attribute '__all__'
(env) $
  • Format setup.py according PEP8
setup.py:1:1: D205 1 blank line required between summary line and description
setup.py:1:1: D400 First line should end with a period
setup.py:11:1: I100 Import statements are in the wrong order. 'import os.path' should be before 'import sys'
setup.py:13:1: I101 Imported names are in the wrong order. Should be find_packages, setup
setup.py:33:1: W293 blank line contains whitespace
setup.py:36:1: D400 First line should end with a period
setup.py:43:1: E305 expected 2 blank lines after class or function definition, found 1
setup.py:66:23: E201 whitespace after '['
setup.py:66:61: E202 whitespace before ']'

WHY

Help people to install easily and follow a standard style format for Python to community easily support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants