-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.0 #135
Draft
patricksanders
wants to merge
59
commits into
main
Choose a base branch
from
develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
v1.0.0 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Start refactoring storage logic to decouple from Flask * Committing refactor progress; persistence abstraction is mostly complete * Add tests for sqlalchemy persistence plugin * blacken existing tests, delete broken docker tests * start new config tests * rework db session handling * isort and clean up, more requirements * remove commented methods in persistence plugin * undo gitignore change * more f-strings, type hints, exception handling * add more sqlalchemy exception handling * blacken recent change
* add WIP implementation of retriever runner and AA retriever * Make a few more things async * support accounts/arns from CLI, make swag calls async * check and transform AA results, store to DB * add some docstrings, handle swag failures better * add tests for access advisor retriever * remove old updater logic * require python 3.8 * fix notification settings * add progress on retriever runner tests * add test requirements to maybe fix travis * specify time zone on datetimes * blacken * use utctimetuple() instead of timetuple() for AA timestamp conversion * add tzinfo to datetime constructors in tests * maybe travis needs to know the time zone * time amirite? * add more runner tests, a bit of refactoring * blacken, add some docstrings * a bit of cleanup * switch from tmpdir_factory fixture to tmp_path * get rid of an old, irrelevant comment Co-authored-by: Curtis Castrapel <[email protected]>
castrapel
reviewed
Jul 22, 2021
aardvark/__init__.py
Outdated
|
||
return app | ||
|
||
|
||
def init_logging(): | ||
log_cfg = { | ||
'version': 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit and double quotes?
castrapel
approved these changes
Jul 22, 2021
patricksanders
had a problem deploying
to
release
September 12, 2024 18:05 — with
GitHub Actions
Failure
patricksanders
had a problem deploying
to
release
September 12, 2024 18:09 — with
GitHub Actions
Failure
patricksanders
had a problem deploying
to
release
September 12, 2024 18:18 — with
GitHub Actions
Failure
patricksanders
had a problem deploying
to
release
September 12, 2024 18:20 — with
GitHub Actions
Failure
patricksanders
had a problem deploying
to
release
September 12, 2024 18:20 — with
GitHub Actions
Failure
patricksanders
temporarily deployed
to
release
September 12, 2024 19:28 — with
GitHub Actions
Inactive
patricksanders
temporarily deployed
to
release
September 12, 2024 19:28 — with
GitHub Actions
Inactive
patricksanders
temporarily deployed
to
release
September 12, 2024 19:32 — with
GitHub Actions
Inactive
patricksanders
temporarily deployed
to
release
September 12, 2024 19:33 — with
GitHub Actions
Inactive
patricksanders
temporarily deployed
to
release
September 12, 2024 19:46 — with
GitHub Actions
Inactive
patricksanders
temporarily deployed
to
release
September 12, 2024 19:47 — with
GitHub Actions
Inactive
patricksanders
temporarily deployed
to
release
September 12, 2024 20:04 — with
GitHub Actions
Inactive
patricksanders
temporarily deployed
to
release
September 12, 2024 20:27 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.