Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add params (MaxDepth and StopOnSysAdmin) and perf increases to Get-SQLServerLinkCrawl #77

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MJVL
Copy link

@MJVL MJVL commented Sep 1, 2022

This PR adds the following enhancements to Get-SQLServerLinkCrawl:

  • Performance increase
    • Crawling will no longer re-visit traversed links (same server with the same user)
    • This avoids circular dependencies, and cut down runtimes from days to a single hour in test environments with tens of servers, hundreds of links, and many circular links
    • Cuts down on noise and query amounts significantly
  • MaxDepth param
    • Allows for a max depth of the crawl, which can help to early exit in large environments
  • StopOnSysAdmin param
    • Stop crawl upon finding the first SysAdmin link

@v-p-b
Copy link

v-p-b commented Dec 3, 2022

Great additions! Resolving circular dependencies is very important, as infinite loops can take cause performance issues on target systems.

@nullbind
Copy link
Collaborator

Im sorry it took me so long to see this. I'll try to review your updates in the next few weeks. Superficially they look great.
Thank you for taking the time to submit the features/fixes!

@MJVL
Copy link
Author

MJVL commented Jul 19, 2024

Im sorry it took me so long to see this. I'll try to review your updates in the next few weeks. Superficially they look great. Thank you for taking the time to submit the features/fixes!

Coming back to this after forgetting about it for a while. Is this still good to review/merge?

@v-p-b
Copy link

v-p-b commented Dec 18, 2024

As an excuse to ping this thread let me mention that without this PR running PowerUpSQL on a real infra represented by the link network graph in the blog post linked from the wiki will likely DoS all servers except the 2014 :)

img_58a5f248bbeda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants