das-pr/custody-subnet-count #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zilm13
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
LGTM, just one nit
also leaving a link to discussion on ENR field to not forget https://github.com/ethereum/consensus-specs/pull/3574/files#r1562393224
| @@ -137,6 +139,11 @@ public void setSyncCommitteeSubnetSubscriptions(Iterable<Integer> subnetIds) { | |||
| .sszSerialize()); | |||
| } | |||
|
|
|||
| public void setDASCustodySubnetCount(int count) { | |||
There was a problem hiding this comment.
let's add extra word into method name so it's clear why it's not set always.
Field name doesn't have anything like extra so at least something should highlight this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add config options to set extra DAS subnets and advertise it with ENR