Fix comm ready check in ncclIbIsend and ncclIbIrecv #1489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ncclIbIsend
&ncclIbIrecv
contains redundant checks forcomm->base.ready
. These checks were made redundant due to a change in commit 5d3ab08, which removed a call toncclSendCheck
that might alter the readiness state of the communicator. The second check forcomm->base.ready
now will never executes.Commit 5d3ab08 Feb 27 2023
Also, the
*request = NULL;
should be kept, as none request is successfully added into the fifo slot, it's safer to assign NULL and consistent with the checkif (sub->requests[buffSlot] != NULL)
in sendProxyProgress.