Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the CUDA call that failed in errors. #1335

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tfogal
Copy link

@tfogal tfogal commented Jul 1, 2024

To make debugging easier.

@kiskra-nvidia
Copy link
Member

Thank you for your contribution!

While on some level more information never hurts, I'm not immediately convinced that this actually makes debugging easier?

WARN messages already include the source file and line number; mapping that info back to a CUDA should be a no-brainer. One could argue that INFO does not do that, but we don't seem to be using CUCHECKIGNORE anywhere in our current codebase.

So could you provide an example of when your PR makes a difference?

@tfogal tfogal marked this pull request as draft July 3, 2024 14:47
@tfogal
Copy link
Author

tfogal commented Jul 3, 2024

We talked offline; this is slightly off the mark.

Follow-up on me to check behavior of GetLastError when the env var is not set and potentially rework this towards the goal of making GetLastError behave differently in that case. Draft mode until we're there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants