forked from hhslepicka/conftrak
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use uri for mongo sb517 #7
Merged
gwbischof
merged 40 commits into
NSLS-II:master
from
JunAishima:use-uri-for-mongo-sb517
Jan 29, 2024
Merged
Use uri for mongo sb517 #7
gwbischof
merged 40 commits into
NSLS-II:master
from
JunAishima:use-uri-for-mongo-sb517
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* would enable running the startup directly from the commandline with the conda env without having to install the code
* @gwbischof recommended this be removed
* enable testing mongomock to be used when configured via the config
* used for testing
* add fixture for service instance * start with simple initial tests
* remove use of utils for startup and teardown
* black formatting * remove old style, non-fixture stuff * remove connection test as it does not work the same way with mongomock
* mongomock moved to testing
JunAishima
force-pushed
the
use-uri-for-mongo-sb517
branch
from
January 25, 2024 18:36
eaa6c97
to
1f35c7e
Compare
* otherwise get the following exception: `ERROR conftrak/test/test_server.py - Failed: Direct construction of _pytest.python.Function has been deprecated, please use _pytest.python.Function.from_parent. See https://docs.pytest.org/en/stable/deprecations.html#node-construction-changed-to-node-from-parent for more details.`
* HTTPClient is synchronous so no yield necessary * using our fixture means the Tornado test base_url does not apply since we set the service port to our normal port
* now using all tornado components, so special package no longer necessary
* LSDC GUI still uses python3.6, while we expect to upgrade python to more recent versions with more support
* prevent mongomock import unless testing mode is activated
gwbischof
reviewed
Jan 26, 2024
gwbischof
approved these changes
Jan 26, 2024
gwbischof
reviewed
Jan 26, 2024
gwbischof
reviewed
Jan 26, 2024
gwbischof
reviewed
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of other changes