Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for discrete DOFs #64

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Conversation

thomaswmorris
Copy link
Contributor

They don't do anything right now, but changing a bit of syntax for later on.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, but looks good overall! Let's fix the mentioned places before merging.

docs/source/agent.rst Outdated Show resolved Hide resolved
scripts/gui.py Show resolved Hide resolved
src/blop/_version.py Outdated Show resolved Hide resolved
src/blop/dofs.py Show resolved Hide resolved
src/blop/dofs.py Outdated Show resolved Hide resolved
src/blop/dofs.py Outdated Show resolved Hide resolved
src/blop/dofs.py Show resolved Hide resolved
src/blop/objectives.py Show resolved Hide resolved
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mrakitin mrakitin merged commit 5e0fc07 into NSLS-II:main Apr 17, 2024
5 checks passed
thomaswmorris pushed a commit to thomaswmorris/blop that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants