Execute new commondata generation in CI #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radonirinaunimi
force-pushed
the
check_newcd
branch
2 times, most recently
from
44f6938 to
47c71b5
Compare
add manual trigger add workflow revert mistakenly deleted file
add filter dependencies as exras & remove underscore
Radonirinaunimi
force-pushed
the
check_newcd
branch
from
dbb3cc9 to
306db71
Compare
|
There are a few datasets that have changed. Many of them are due to numerical fluctuations, so #2095 needs to be propagated. List of datasets that have been modified |
Radonirinaunimi
commented
Jul 31, 2024
There was a problem hiding this comment.
Looking at the datasets one-by-one, the changes in the uncertainties are due to:
- numerical fluctuations which are solved by Don't save more decimals than necessary in the uncertainty (or data) files #2095
- changes of signs due to the decomposition of the covmats (cc @enocera).
There are only a few datasets (CMS_1JET_8TEV and some of the STAR data [cc @giacomomagni]) for which there are changes not attributed to one of the above.
nnpdf_data/nnpdf_data/new_commondata/STAR_2013_2JET_510GEV/uncertainties_A.yaml
Outdated
Show resolved
Hide resolved
nnpdf_data/nnpdf_data/new_commondata/STAR_2013_2JET_510GEV/uncertainties_B.yaml
Outdated
Show resolved
Hide resolved
nnpdf_data/nnpdf_data/new_commondata/STAR_2013_2JET_510GEV/uncertainties_C.yaml
Outdated
Show resolved
Hide resolved
nnpdf_data/nnpdf_data/new_commondata/CMS_1JET_8TEV/uncertainties.yaml
Outdated
Show resolved
Hide resolved
|
@Radonirinaunimi do we want to try to merge this before going through the actual data? |
Sorry for the late reply, for some reasons I have not received notifications about this. Yes, let me resolve these merge conflicts tomorrow and then we can try to merge. As far as I recall, there is only one single dataset that I need to look really closer. |
scarlehoff
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Thank you very much for this. This is really fantastic.
I've added the fitbot flag thinking about maybe small changes but I don't actually think it is necessary seeing that the regression tests have not changed.
We might want to wait until it finish since it is already running though.
|
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
scarlehoff
added
run-fit-bot
|
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
scarlehoff
added
run-fit-bot
|
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1457 but also:
filter.pyworks properlyRemaining to do:
nnpdf_data/nnpdf_data/new_commondata