Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual data normalisation and author verification #533

Closed
wants to merge 1 commit into from

Conversation

SeverusYixin
Copy link
Collaborator

Due to a bug in the data_normalizer where it fails to properly normalize the raw data from GitHub after execution, the data is being manually normalized for now. Additionally, the authors' names have been manually reviewed and verified.

Due to a bug in the data_normalizer where it fails to properly normalize the raw data from GitHub after execution, the data is being manually normalized for now. Additionally, the authors' names have been manually reviewed and verified.
@SeverusYixin
Copy link
Collaborator Author

SeverusYixin commented Nov 28, 2024

Hi @haesleinhuepf, would mind checking this PR :) And merge it :)

Thank you!

- Jens Wendt
- Maximilian Müller
- "Maximilian M\xFCller"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SeverusYixin ,

I'm not sure if this modification is a good idea. The yml file becomes less readable. Furthermore, on the website this entry looks ok:

image

Can you explain why you want to change this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @haesleinhuepf , Thank you for your feedback! 😊 First, I would like to clarify that I haven’t made any changes to the script—it has always worked this way. Let’s try to recall the discussion we had earlier: when I asked you about this, I mentioned that normalizing the output might result in something like this in the YAML file. At the time, you mentioned that as long as it displayed correctly on the website, you were fine with how it appeared in the YAML file.
That said, I agree that as the Data_content grows, improving readability in the YAML file could indeed benefit maintenance. To address this, I’ll go ahead and create an issue to propose modifying this output for better readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants