Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a new smart normalization rules #516

Closed
wants to merge 1 commit into from
Closed

Implement a new smart normalization rules #516

wants to merge 1 commit into from

Conversation

SeverusYixin
Copy link
Collaborator

This PR related to #512
This PR closes #512

This was referenced Nov 26, 2024
Open
Closed
@SeverusYixin
Copy link
Collaborator Author

SeverusYixin commented Nov 26, 2024 •
edited
Loading

Hi @haesleinhuepf, whenever you have time to review this PR, I’d appreciate it! Once it’s merged, I can go ahead and add the PR function to it.

Also have a good evening !

haesleinhuepf
haesleinhuepf reviewed Nov 26, 2024
View reviewed changes
scripts/data_normalizer.py

# Split the authors string by ';' if it contains multiple authors
if ';' in authors:
author_names = authors.split(';')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old code was obviously able to handle cases with ; as delimiter. Why do you remove this feature?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because the new material currently added does not include this type, I removed it. Of course, it is also a good choice to keep it.

@haesleinhuepf
Copy link
Member

add the PR function to it.

I do not understand. What do you want to add where?

@SeverusYixin
Copy link
Collaborator Author

SeverusYixin commented Nov 27, 2024 •
edited
Loading

add the PR function to it.

I do not understand. What do you want to add where?

As mentioned in this comment: #474 (comment), this is only a normalizer. Similar to GitHub Actions, it is invoked solely to normalize the YAML file, without performing any save operations.

And to create a PR or save function is next new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haesleinhuepf haesleinhuepf haesleinhuepf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a new normalization rule for the updated data format.
2 participants
@SeverusYixin @haesleinhuepf