Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend 4: Render categorical palette #2445

Merged
merged 8 commits into from
Jun 20, 2024

Conversation

yvonnesjy
Copy link
Collaborator

No description provided.

src/js/views/maps/legend/LayerLegendView.js Outdated Show resolved Hide resolved
@yvonnesjy yvonnesjy force-pushed the feature-1784-categorical-palette branch from d5047ee to 972b814 Compare June 12, 2024 22:30
@yvonnesjy yvonnesjy linked an issue Jun 13, 2024 that may be closed by this pull request
@yvonnesjy yvonnesjy force-pushed the feature-1784-categorical-palette branch from 972b814 to 2666bd9 Compare June 17, 2024 19:28
src/js/models/maps/AssetColor.js Outdated Show resolved Hide resolved
@yvonnesjy yvonnesjy force-pushed the feature-1784-categorical-palette branch from 2666bd9 to ae911f5 Compare June 17, 2024 23:17
@robyngit
Copy link
Member

@yvonnesjy there are some tests failing other than the eslint errors, see https://github.com/NCEAS/metacatui/actions/runs/9556159324/job/26377186438?pr=2445.

Prettier formatting needed for:

  • src/css/map-view.css
  • test/js/specs/unit/views/maps/legend/LayerLegendView.spec.js

And one unit test is not passing:

FAILS:  1
PASSES: 553
Failed Tests: 
-------------

[1]: LegendContainerView Test Suite
     > toggleExpanded
     > AssertionError: expected false to be true
    at Context.<anonymous> (js/specs/unit/views/maps/legend/LegendContainerView.spec.js?v=undefined:99:49)

This is easy to miss if we're ignoring the ESlint failures. Maybe we need to change the github action in someway to make it clearer which have failed and which are passing.

@yvonnesjy yvonnesjy force-pushed the feature-1784-categorical-palette branch from d3ed4c9 to d03d03d Compare June 18, 2024 19:24
@yvonnesjy
Copy link
Collaborator Author

Ah thanks for catching! Fixed. Is there a way to only mark eslint failure as warning for now?

I also pushed a commit that incorporates the label fixes

  • <layer name> (<property label || property name>): Not reflected in mock yet but I got a 👍🏻 from Doug on this formatting
  • <color label> || <color value> for categorical swatch

@yvonnesjy yvonnesjy requested a review from robyngit June 18, 2024 19:27
@yvonnesjy yvonnesjy force-pushed the feature-1784-categorical-palette branch from d03d03d to 38ea2c8 Compare June 20, 2024 17:47
@yvonnesjy yvonnesjy merged commit 16d1b75 into NCEAS:develop Jun 20, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show a legend for data layers that require one in the Cesium View
3 participants