-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legend 4: Render categorical palette #2445
Legend 4: Render categorical palette #2445
Conversation
d5047ee
to
972b814
Compare
972b814
to
2666bd9
Compare
2666bd9
to
ae911f5
Compare
@yvonnesjy there are some tests failing other than the eslint errors, see https://github.com/NCEAS/metacatui/actions/runs/9556159324/job/26377186438?pr=2445. Prettier formatting needed for:
And one unit test is not passing:
This is easy to miss if we're ignoring the ESlint failures. Maybe we need to change the github action in someway to make it clearer which have failed and which are passing. |
d3ed4c9
to
d03d03d
Compare
Ah thanks for catching! Fixed. Is there a way to only mark eslint failure as warning for now? I also pushed a commit that incorporates the label fixes
|
Co-authored-by: Robyn <[email protected]>
- Include property name of each palette - Prioritize color's label over color's value
d03d03d
to
38ea2c8
Compare
No description provided.