[DO NOT MERGE] Comparison of main + original #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 22, 2023 14:56
…ter - still needs testing
|
Is there a specific reason you've chosen to treat edges/corners/MPI domain edges with separate loops rather than using ghost points? |
|
The reason that edges etc were done in this way, rather than multiplying by zero for e.g., was to replicate the floating point operations exactly. So there are the same number of multiplications, and no reference to precomputed values or changing the indexing of the vectors. |
|
To what end? Are we wanting to compare the performance of the matrix and matrix-free versions that precisely? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to compare and discuss the matrix-free, stencil version of the original HPCG