Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New example field 11: discrete sampling geometry trajectory features #290

Merged
merged 4 commits into from
Feb 27, 2024
Merged

New example field 11: discrete sampling geometry trajectory features #290

merged 4 commits into from
Feb 27, 2024

Conversation

davidhassell
Copy link
Contributor

Fixes #289

@davidhassell davidhassell added this to the 1.11.1.0 milestone Feb 26, 2024
@davidhassell davidhassell mentioned this pull request Feb 26, 2024
Merged
sadielbartholomew
sadielbartholomew approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor update required relating to an error message, but otherwise all good and please merge when ready. This new example field looks useful so thanks for adding it.

cfdm/test/test_functions.py Outdated Show resolved Hide resolved
@davidhassell
Copy link
Contributor Author

Missing units fixed: a79c709

sadielbartholomew
sadielbartholomew approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All feedback addressed well, including that raised off-line RE units mysteriously disappearing. I ran the test suite locally and it still passes. Brill, please merge.

@davidhassell davidhassell merged commit 9d911e9 into NCAS-CMS:main Feb 27, 2024
@davidhassell davidhassell deleted the trajectory-example branch February 27, 2024 16:11
@davidhassell davidhassell added enhancement New feature or request testing Issues related to units tests and their coverage labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request testing Issues related to units tests and their coverage
Projects
None yet
Milestone
1.11.1.0
Development

Successfully merging this pull request may close these issues.

New example field: discrete sampling geometry trajectory features
2 participants
@davidhassell @sadielbartholomew