Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In cf.read, skip caching elements from compression index variables. #671

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

davidhassell
Copy link
Collaborator

@davidhassell davidhassell commented Jun 19, 2023

Requires cfdm 1.10.1.1, specifically NCAS-CMS/cfdm#260 (Edit 2023-06-20: now merged into main), from which it utilises the new compression_index keyword parameter of NetCDF._create_data.

@davidhassell davidhassell added the performance Relating to speed and memory performance label Jun 19, 2023
@davidhassell davidhassell added this to the Next release milestone Jun 19, 2023
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but works and incorporates the speedup successfully. Please merge when ready.

cf/read_write/netcdf/netcdfread.py Outdated Show resolved Hide resolved
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell davidhassell merged commit 9f676f5 into NCAS-CMS:main Jun 20, 2023
@davidhassell davidhassell deleted the cache-compressed branch June 20, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Relating to speed and memory performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants