Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hasura relationships to support Expansion Runs UI #957

Merged
merged 1 commit into from
May 31, 2023

Conversation

jeffpamer
Copy link
Contributor

Required for NASA-AMMOS/aerie-ui#577

  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

Adds the following object/array relationships:

  • expanded_sequences . ( seq_id, simulation_dataset_id ) → sequence . ( seq_id, simulation_dataset_id )
  • expanded_sequences . expansion_run_id → expansion_run . id

Allowing the UI to gather the necessary details to display information about the expanded sequences and the applicable activity types within each expansion/sequence.

Verification

Upon rebuilding, confirmed the following query ran successfully in the Hasura API Explorer

{
  expansionRuns: expansion_run(order_by: {id: desc}) {
    created_at
    expansion_set {
      command_dict_id
      created_at
      id
      name
    }
    expanded_sequences {
      edsl_string
      expanded_sequence
      id
      seq_id
      sequence {
        activity_instance_joins {
          simulated_activity {
            id
            activity_type_name
          }
        }
      }
    }
    simulation_dataset {
      dataset_id
      simulation {
        plan {
          id
          name
        }
      }
    }
    id
  }
}

Documentation

N/A

Future work

N/A

@jeffpamer jeffpamer requested a review from a team as a code owner May 31, 2023 00:04
@jeffpamer jeffpamer requested review from cohansen and Mythicaeda May 31, 2023 00:04
Copy link
Contributor

@Mythicaeda Mythicaeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and it LGTM!

@jeffpamer
Copy link
Contributor Author

I'm assuming the e2e test is failing due to intermittent failures unrelated to this change? But please let me know if I'm likely wrong in that assumption and I'll check back in the morning!

@jeffpamer jeffpamer temporarily deployed to e2e-test May 31, 2023 04:08 — with GitHub Actions Inactive
Copy link
Contributor

@cohansen cohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I see the e2e tests are passing now, did they fail on an earlier run?

@jeffpamer
Copy link
Contributor Author

Looks good to me! I see the e2e tests are passing now, did they fail on an earlier run?

Yeah it looks like the first two attempts failed, but third time was the charm. Thank you for the review!

@jeffpamer jeffpamer merged commit 86a5d35 into develop May 31, 2023
@jeffpamer jeffpamer deleted the feature/expansion-run-relationships branch May 31, 2023 15:37
@camargo camargo added the refactor A code change that neither fixes a bug nor adds a feature label Jun 1, 2023
@camargo camargo added this to the FY23 Q3 - Ad Hoc Improvements milestone Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants