Add plan id and sim dataset id to seq JSON #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cohansen
force-pushed
the
feature/add-plan-id-and-sim-dataset-id-to-seq
branch
from
d3bcd6e to
ca39aef
Compare
camargo
changed the title
camargo
changed the title
camargo
requested review from
camargo
and removed request for
skovati and
JoelCourtney
cohansen
changed the base branch from
develop
to
style/format-sequencing-server
cohansen
force-pushed
the
feature/add-plan-id-and-sim-dataset-id-to-seq
branch
from
ca39aef to
8f3b7f0
Compare
camargo
reviewed
Dec 20, 2022
sequencing-server/src/lib/batchLoaders/simulatedActivityBatchLoader.ts
Outdated
Show resolved
Hide resolved
dyst5422
reviewed
Dec 20, 2022
sequencing-server/src/lib/batchLoaders/simulatedActivityBatchLoader.ts
Outdated
Show resolved
Hide resolved
cohansen
force-pushed
the
feature/add-plan-id-and-sim-dataset-id-to-seq
branch
from
155a04b to
f3fe899
Compare
Added planId and simulationDatasetId to the tests Switched to using the planId from the simuation dataset rather than the activity directive Removed the 0 duration error for now
cohansen
force-pushed
the
feature/add-plan-id-and-sim-dataset-id-to-seq
branch
from
f3fe899 to
56123d9
Compare
camargo
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Automatically adds
planIdandsimulationDatasetIdto the top level sequence metadata.Verification
Double checked in the UI and updated all the tests to include the new metadata properties.
Documentation
NA
Future work
NA